euccas edited a comment on pull request #20122: URL: https://github.com/apache/airflow/pull/20122#issuecomment-989129946
Thanks for the comment @ashb. This is my first PR, yes I could work out adding the unit tests, that was what I have been doing actually, I just didn't expect this PR gets reviewed so quickly 😄 To the point 3 (this is the most important), I looked at this open feature request https://github.com/apache/airflow/issues/16790, it seems that the feature discussed there is a bit different from the purpose of my PR, and more importantly these two features are not mutually exclusive to each other. That Task Note idea is to add a dedicated Tab in the Task view, where it shows all the notes associated with a task, and users can add all types of notes about the task itself. What my PR does is adding an input box in the confirmation page where users would see after they clear/mark success/mark failed a DAG run or a task instance. In my understanding, both would help improve auditability of Airflow. @ashb what do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
