[GitHub] [airflow] hwooson12 commented on a change in pull request #20002: Add hour and minute to time format on x-axis of all charts using nvd3.lineChart

Wed, 08 Dec 2021 16:27:21 -0800 


hwooson12 commented on a change in pull request #20002:
URL: https://github.com/apache/airflow/pull/20002#discussion_r765344252



##########
File path: airflow/www/views.py
##########
@@ -136,6 +136,11 @@
 PAGE_SIZE = conf.getint('webserver', 'page_size')
 FILTER_TAGS_COOKIE = 'tags_filter'
 FILTER_STATUS_COOKIE = 'dag_status_filter'
+LINECHART_X_AXIS_TICKFORMAT = (
+    "function (d, i) { let xLabel;"
+    "if (i === undefined) {xLabel = d3.time.format('%H:%M, %d %b %Y')(new 
Date(parseInt(d)));"
+    "} else {xLabel = d3.time.format('%H:%M')(new Date(parseInt(d)));} return 
xLabel;}"

Review comment:
       
![image](https://user-images.githubusercontent.com/16971553/145312210-a9d0f207-4f51-4bda-8fb4-9e56076325b6.png)
   
   Your suggestion looks pretty better than showing only the hh:mm 👍




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to