uranusjr commented on a change in pull request #20163:
URL: https://github.com/apache/airflow/pull/20163#discussion_r765725893
##########
File path: airflow/utils/db.py
##########
@@ -882,12 +883,12 @@ def _move_dangling_task_data_to_new_table(session,
source_table: "Table", target
_move_dangling_table(session, source_table, target_table_name,
where_clause)
-def check_task_tables_without_matching_dagruns(session) -> Iterable[str]:
+def check_task_tables_without_matching_dagruns(session: Session) ->
Iterable[str]:
import sqlalchemy.schema
from sqlalchemy import and_, outerjoin
metadata = sqlalchemy.schema.MetaData(session.bind)
- models_to_dagrun = [TaskInstance, TaskReschedule]
+ models_to_dagrun: List[Any] = [TaskInstance, TaskReschedule]
Review comment:
Technically we can type this (what we want is the `__tablename__`
attribute from SQLAlchemy), but SQLAlchemy is so dynamic, adding accurate type
here does not really help much, so I don’t really want to bother.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
