[
https://issues.apache.org/jira/browse/AIRFLOW-4393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16840216#comment-16840216
]
ASF GitHub Bot commented on AIRFLOW-4393:
-----------------------------------------
oliviervg1 commented on pull request #5284: [AIRFLOW-4393] Add retry logic when
fetching pod status and/or logs in KubernetesPodOperator
URL: https://github.com/apache/airflow/pull/5284
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-4393
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
Added an exponential backoff retry to the Kube pod launcher when reading
info / fetching logs from running pods. This is to mitigate any transient
network issues, which could cause Airflow to mark the task as failed and launch
a new pod without removing the old one.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
### Code Quality
- [x] Passes `flake8`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add retry logic when fetching pod status and/or logs in KubernetesPodOperator
> -----------------------------------------------------------------------------
>
> Key: AIRFLOW-4393
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4393
> Project: Apache Airflow
> Issue Type: Bug
> Reporter: Olivier Van Goethem
> Priority: Minor
>
> Over the last weeks we have observed 2 occasions where:
> * KubernetesPodOperator successfully launches the pod
> * KubernetesPodOperator then fails when attempting to check the pod
> status/logs due to:
> {code:java}
> NewConnectionError('<urllib3.connection.VerifiedHTTPSConnection object at
> 0x7f1329dc0cf8>: Failed to establish a new connection: [Errno 111] Connection
> refused',)
> {code}
> * KubernetesPodOperator launches another pod
> * We now have 2 pods running in parallel
> The cause for the 'Connection refused' is due to a transient network error.
> As such, the KubernetesPodOperator should attempt to retry checking the pod
> status/logs rather than failing the task.
> Airflow is being run through GCP's Cloud Composer.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
