dstandish commented on a change in pull request #19665:
URL: https://github.com/apache/airflow/pull/19665#discussion_r765957126
##########
File path: tests/providers/amazon/aws/sensors/test_redshift.py
##########
@@ -39,8 +39,6 @@ def _create_cluster():
MasterUsername='admin',
MasterUserPassword='mock_password',
)
- if not client.describe_clusters()['Clusters']:
- raise ValueError('AWS not properly mocked')
Review comment:
i think this may not have been intended
##########
File path: airflow/providers/amazon/aws/sensors/redshift.py
##########
@@ -48,7 +48,7 @@ def __init__(
self.hook: Optional[RedshiftHook] = None
def poke(self, context):
- self.log.info('Poking for status : %s\nfor cluster %s',
self.target_status, self.cluster_identifier)
+ self.log.info('Checking cluster %r for status %r',
self.cluster_identifier, self.target_status)
Review comment:
probablly best to remove this change too since it's unrelated. it made
sense when you were changing everything to enum and touching this bit of code
anyway. but not anymore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
