eladkal commented on a change in pull request #20151:
URL: https://github.com/apache/airflow/pull/20151#discussion_r766004696
##########
File path: airflow/jobs/scheduler_job.py
##########
@@ -145,6 +145,12 @@ def __init__(
self.dagbag = DagBag(dag_folder=self.subdir, read_dags_from_db=True,
load_op_links=False)
+ if conf.getboolean('smart_sensor', 'use_smart_sensor'):
+ warnings.warn(
+ 'Smart sensors are deprecated. Please use Deferrable Operators
instead.',
Review comment:
If we can be more explicit about what needs to be done - we should.
However I believe that if we know that a feature is deprecated we should say
it as soon as possible - regardless if we have all the needed docs /
explanations. At the end the explanations are for users who need to migrate
from the deprecated features to the new one BUT there are also users who may
just now playing with the feature and thinking to start use it - for them we
just need to say that it's deprecated. They don't need migration docs.
So this is a tradeoff. i'm happy with what we have so far. We can always add
more information.
Also want to add that we've been in this case before :)
TaskGroups <-> SubDags are also not 1-to-1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
