khalidmammadov commented on a change in pull request #20120:
URL: https://github.com/apache/airflow/pull/20120#discussion_r764642038



##########
File path: airflow/www/views.py
##########
@@ -543,7 +543,7 @@ class AirflowBaseView(BaseView):
     }
 
     if not conf.getboolean('core', 'unit_test_mode'):
-        extra_args['sqlite_warning'] = settings.Session.bind.dialect.name == 
'sqlite'
+        extra_args['sqlite_warning'] = settings.Session.bind.dialect.name == 
'sqlite'  # type: ignore

Review comment:
       Ok, thanks for pointing out that PR, wasnt aware it's being fixed. I 
will rollback this file or
   
   > 
   
   Ok, thanks for pointing out that PR, wasnt aware it's being fixed. I will 
rollback this file

##########
File path: airflow/www/extensions/init_appbuilder.py
##########
@@ -560,7 +561,7 @@ def security_converge(self, dry=False) -> Dict:
         :param dry: If True will not change DB
         :return: Dict with all computed necessary operations
         """
-        return self.sm.security_converge(self.baseviews, self.menu, dry)
+        return self.sm.security_converge(self.baseviews, self.menu, dry)  # 
type: ignore

Review comment:
       Tried, still the same. I am not sure where that method is coming from, 
will need to dig deeper




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to