kaxil commented on a change in pull request #19572:
URL: https://github.com/apache/airflow/pull/19572#discussion_r766956061
##########
File path: tests/providers/cncf/kubernetes/operators/test_kubernetes_pod.py
##########
@@ -762,17 +789,27 @@ def test_mark_reattached_pod_if_not_deleted(self,
mock_patch_already_checked, mo
task_id="task",
is_delete_operator_pod=False,
)
- # Run it first to easily get the pod
- pod = self.run_pod(k)
-
- # Now try and "reattach"
- mock_patch_already_checked.reset_mock()
- mock_delete_pod.reset_mock()
- self.client_mock.return_value.list_namespaced_pod.return_value.items =
[pod]
- self.monitor_mock.return_value = (State.FAILED, None, None)
+ remote_pod_mock = MagicMock()
+ remote_pod_mock.status.phase = 'Failed'
+ self.await_pod_mock.return_value = remote_pod_mock
- context = self.create_context(k)
+ context = create_context(k)
with pytest.raises(AirflowException):
k.execute(context=context)
mock_patch_already_checked.assert_called_once()
mock_delete_pod.assert_not_called()
+
+
+def test_suppress_with_logging():
+ with mock.patch('logging.Logger.error') as mock_error:
+
+ class A:
+ log = logging.getLogger()
+
+ def fail(self):
+ with _suppress_with_logging(self, ValueError):
+ raise ValueError("failure")
+
+ a = A()
+ a.fail()
+ mock_error.assert_called_once_with("failure", exc_info=True)
Review comment:
`test_suppress_with_logging` is not called anywhere so how does it work?
Feels really odd and if we want to use it needs lot of comments in the code
about the definition explaining for future devs on what it does and why
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
