dstandish commented on a change in pull request #19572:
URL: https://github.com/apache/airflow/pull/19572#discussion_r766965372
##########
File path: airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py
##########
@@ -163,8 +175,14 @@ class KubernetesPodOperator(BaseOperator):
:param termination_grace_period: Termination grace period if task killed
in UI,
defaults to kubernetes default
:type termination_grace_period: int
+
+ TODO: ``is_delete_operator_pod`` default should be True
Review comment:
this was a discussion point in the early part of the process for this
operator. @jedcunningham suggested taking the opportunity to fix a few things
as part of the refactor. along with removing some of the duplication, he
suggested flipping delete pod to True, and adding support for usage of k8s
hook. if you're cool with both of these changes, i can add them both to this
PR. or we can defer them -- either way i can remove that TODO but let's
resolve what to do here first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
