potiuk commented on issue #4779: [AIRFLOW-3958] List tasks upstream work in 
chain
URL: https://github.com/apache/airflow/pull/4779#issuecomment-492955694
 
 
   I still think adding docs in the same PR is necessary. I am in favour of 
adding documentation together with the relevant code that is modified. 
   
   Especially in this case, this is a new way of building the DAG relationships 
which is the "core" of Airflow really and everyone should now how to use it. 
Having some PR / slack discussion describing such feature is really bad way of 
documenting it. Especially that this discussion was long and had many twists so 
it is unclear what the final intention was without reading the whole thread.
   
   Also several other people had their strong opinions here so maybe it's good 
if everyone who participated will state their opinion on the current code. I 
don't think we all have to fully agree but maybe just one last round of 
comments would be great, then documentation should be added to reflect it and 
then we merge it. @zhongjiajie @feng-tao @Fokko @feluelle @mik-laj @XD-DENG ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to