potiuk commented on a change in pull request #20212:
URL: https://github.com/apache/airflow/pull/20212#discussion_r767167283
##########
File path: airflow/providers/snowflake/hooks/snowflake.py
##########
@@ -135,7 +137,7 @@ def __init__(self, *args, **kwargs) -> None:
self.schema = kwargs.pop("schema", None)
self.authenticator = kwargs.pop("authenticator", None)
self.session_parameters = kwargs.pop("session_parameters", None)
- self.query_ids = []
+ self.query_ids: List[str] = []
Review comment:
Agree. this makes the hook re-runnable/
##########
File path: airflow/providers/snowflake/operators/snowflake.py
##########
@@ -230,7 +230,7 @@ def __init__(
self.schema = schema
self.authenticator = authenticator
self.session_parameters = session_parameters
- self.query_ids = []
+ self.query_ids: List[str] = []
Review comment:
Strange that it's not inferred automatically here. But it does not hurt.
##########
File path: airflow/providers/snowflake/operators/snowflake.py
##########
@@ -230,7 +230,7 @@ def __init__(
self.schema = schema
self.authenticator = authenticator
self.session_parameters = session_parameters
- self.query_ids = []
+ self.query_ids: List[str] = []
Review comment:
But maybe you can remove it since the docstring needs to be fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
