kaxil commented on a change in pull request #20178:
URL: https://github.com/apache/airflow/pull/20178#discussion_r767831855
##########
File path: airflow/jobs/scheduler_job.py
##########
@@ -327,6 +327,17 @@ def _executable_task_instances_to_queued(self, max_tis:
int, session: Session =
self.log.warning("Tasks using non-existent pool '%s' will not
be scheduled", pool)
continue
+ pool_total = pools[pool]["total"]
+ if task_instance.pool_slots > pool_total:
+ self.log.warning(
+ "Not executing %s since requesting %s slots when total
pool '%s' slots are %s.",
+ task_instance,
+ task_instance.pool_slots,
+ pool,
+ pool_total,
+ )
Review comment:
```suggestion
self.log.warning(
"Not executing %s. Requested pool slots (%s) are greater
than total pool slots: '%s' for pool: %s.",
task_instance,
task_instance.pool_slots,
pool_total,
pool,
)
```
##########
File path: airflow/jobs/scheduler_job.py
##########
@@ -327,6 +327,17 @@ def _executable_task_instances_to_queued(self, max_tis:
int, session: Session =
self.log.warning("Tasks using non-existent pool '%s' will not
be scheduled", pool)
continue
+ pool_total = pools[pool]["total"]
+ if task_instance.pool_slots > pool_total:
+ self.log.warning(
+ "Not executing %s since requesting %s slots when total
pool '%s' slots are %s.",
+ task_instance,
+ task_instance.pool_slots,
+ pool,
+ pool_total,
+ )
Review comment:
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
