ashb commented on a change in pull request #19914:
URL: https://github.com/apache/airflow/pull/19914#discussion_r768143383
##########
File path: airflow/utils/email.py
##########
@@ -226,9 +228,9 @@ def send_mime_email(
if smtp_starttls:
conn.starttls()
if smtp_user and smtp_password:
- conn.login(smtp_user, smtp_password)
+ conn.login(smtp_user if smtp_user else "", smtp_password)
log.info("Sent an alert email to %s", e_to)
- conn.sendmail(e_from, e_to, mime_msg.as_string())
+ conn.sendmail(e_from if e_from else "", e_to, mime_msg.as_string())
Review comment:
I don't think this is actually valid -- SMPT requires an address in
"MAIL FROM".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
