jedcunningham commented on a change in pull request #20199:
URL: https://github.com/apache/airflow/pull/20199#discussion_r768179979
##########
File path: chart/values.schema.json
##########
@@ -2158,12 +2158,12 @@
},
"default": [
{
- "port": "airflow-ui"
+ "port": "{{
.Values.ports.airflowUI }}"
}
],
"examples": [
{
- "port": "sidecar"
+ "port": "8080"
Review comment:
I think I'd rather see the sidecar examples still, or at least use a
non-default int port.
##########
File path: chart/tests/test_flower.py
##########
@@ -352,7 +352,7 @@ def test_defaults(self):
assert [{"namespaceSelector": {"matchLabels": {"release":
"myrelease"}}}] == jmespath.search(
"spec.ingress[0].from", docs[0]
)
- assert [{"port": "flower-ui"}] ==
jmespath.search("spec.ingress[0].ports", docs[0])
+ assert [{"port": 5555}] == jmespath.search("spec.ingress[0].ports",
docs[0])
Review comment:
This look good, but we should move the named-port coverage into the
following test, `test_ports_overrides`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
