ferruzzi opened a new issue #20296: URL: https://github.com/apache/airflow/issues/20296
### Description Follow-up to Restructure Amazon provider operators files [#20139](https://github.com/apache/airflow/issues/20139) as discussed with @eladkal Amazon Operators are inconsistently named regarding acronym capitalization across the Operators, and whether to prefix with AWS or not. An incomplete list for example: we have `SnsPublishOperator` but we capitalize the acronyms in `SQSPublishOperator` and `ECSOperator`. We prefix `AwsGlueCrawlerOperator` and `AwsBatchOperator` in lowercase, `AWSAthenaOperator` is prefixed in uppercase, and no prefix at all on `GlacierCreateJobOperator`or `CloudFormationCreateStackOperator` Correct naming conventions are listed in AIP 21 cases [3-4](https://cwiki.apache.org/confluence/display/AIRFLOW/AIP-21%3A+Changes+in+import+paths#AIP21:Changesinimportpaths-Case#3{aws/azure/gcp}_*) and case [6](https://cwiki.apache.org/confluence/display/AIRFLOW/AIP-21%3A+Changes+in+import+paths#AIP21:Changesinimportpaths-Case#6Otherisolatedcases). The sensors/operators class names should not have Aws/AWS as part of the class name and only the first letter of the acronyms should be capitalized. So: SnsPublishOperator -> No change SQSPublishOperator -> SqsPublishOperator AwsBatchOperator -> BatchOperator AWSAthenaOperator -> AthenaOperator etc... ### Use case/motivation For each task: -Rename the operator -Deprecate the old name -Correct any references to the old name in docstrings and docs files. ### Changes Required: **Operators:** | Current | New Name | |------------------------------|--------------------------| | AWSAthenaOperator | AthenaOperator | | AwsBatchOperator | BatchOperator | | AWSDataSyncOperator | DataSyncOperator | | EC2StartInstanceOperator | Ec2StartInstanceOperator | | ECSProtocol | EcsProtocol | | ECSTaskLogFetcher | EcsTaskLogFetcher | | ECSOperator | EcsOperator | | EKS***Operator (all of them) | Eks***Operator | | RedshiftSQLOperator | RedshiftSqlOperator | | SQSPublishOperator | SqsPublishOperator | **Sensors:** | Current | New Name | |----------------------------|------------------------| | EC2InstanceStateSensor | Ec2InstanceStateSensor | | EKS***Sensor (all of them) | Eks***Sensor | | AwsRedshiftClusterSensor | RedshiftClusterSensor | | SQSSensor | SqsSensor | ### Action Items: **Operators:** - [ ] athena.py - [ ] batch.py - [ ] datasync.py - [ ] ecs.py - [ ] eks.py - [ ] glue_crawler.py - [ ] redshift.py - [ ] sqs.py **Sensors:** - [ ] ec2_instance_state.py (possibly rename file to just ec2.py to match the one-file-per-service convention as well?) - [ ] eks.py - [ ] redshift.py - [ ] sqs.py ### To be verified (recently changed in the linked campaign): DMS EC2 EMR Glue S3 Sagemaker --- ### No changes required: **Operators:** CloudFormationCreateStackOperator CloudFormationDeleteStackOperator GlacierCreateJobOperator SnsPublishOperator StepFunctionGetExecutionOutputOperator StepFunctionStartExecutionOperator AthenaSensor CloudFormationCreateStackSensor CloudFormationDeleteStackSensor DmsTaskBaseSensor DmsTaskCompletedSensor **Sensors:** GlacierJobOperationSensor StepFunctionExecutionSensor ### Related issues https://github.com/apache/airflow/issues/20139 ### Are you willing to submit a PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
