kazanzhy commented on a change in pull request #20301:
URL: https://github.com/apache/airflow/pull/20301#discussion_r769077799
##########
File path: airflow/providers/apache/beam/operators/beam.py
##########
@@ -57,8 +57,8 @@ def _set_dataflow(
def __set_dataflow_hook(self) -> DataflowHook:
self.dataflow_hook = DataflowHook(
- gcp_conn_id=self.dataflow_config.gcp_conn_id or self.gcp_conn_id,
- delegate_to=self.dataflow_config.delegate_to or self.delegate_to,
+ gcp_conn_id=self.dataflow_config.gcp_conn_id or self.gcp_conn_id,
# type: ignore[attr-defined]
+ delegate_to=self.dataflow_config.delegate_to or self.delegate_to,
# type: ignore[attr-defined]
poll_sleep=self.dataflow_config.poll_sleep,
Review comment:
In this place, I have to use ignore.
I assumed that using "Protocol" from `typing` will make the code
overcomplicated. But if you insist I'll implement `Protocol`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
