potiuk edited a comment on issue #19891:
URL: https://github.com/apache/airflow/issues/19891#issuecomment-994758499


   1) the mixin has no super class. super().execute() will only work because 
Mixin is only applied to an Operator where BaseOperator has an execute() 
method. We could create a custom protocol for the mixin, but I think in this 
case #type: ignore with appropriate comment should be good. 
   
   2) The get_db_hook() from BaseSQLOperator expects DBAPIHook to be returned. 
QBoleCheckHook does not extend DBAPIHook. Just extending from DBAPIHook should 
help.
   
   
   Comment - this class hierarchy for Qubole is a mess. You can even see 
comment from @xinbinhuang which I very much agree with:
   
   | # TODO(xinbinhuang): refactor to reduce levels of inheritance
   
   
   But I think this is for another time (and likely someone from Qubole team to 
take care about it. Anyone from Qubole listening ;) ?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to