subkanthi commented on a change in pull request #20291:
URL: https://github.com/apache/airflow/pull/20291#discussion_r769820486



##########
File path: airflow/providers/exasol/hooks/exasol.py
##########
@@ -143,7 +143,9 @@ def export_to_file(
             )
         self.log.info("Data saved to %s", filename)
 
-    def run(self, sql: Union[str, list], autocommit: bool = False, parameters: 
Optional[dict] = None) -> None:
+    def run(
+        self, sql: Union[str, list], autocommit: bool = False, parameters: 
Optional[dict] = None, handler=None

Review comment:
       The error here is because of signature not matching the run() in 
DbApiHook and adding the handler parameter fixes it.
   
   ```
   mypy --namespace-packages airflow/providers/exasol/hooks
   airflow/providers/exasol/hooks/exasol.py:146: error: Signature of "run" 
incompatible with supertype "DbApiHook"
           def run(
           ^
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to