jedcunningham commented on a change in pull request #18808:
URL: https://github.com/apache/airflow/pull/18808#discussion_r769880190



##########
File path: chart/values.schema.json
##########
@@ -1685,6 +1685,21 @@
                         }
                     }
                 },
+                "extraContainers": {
+                    "description": "Launch additional containers for the 
create user job pod",
+                    "type": "array",
+                    "default": []
+                },
+                "extraVolumes": {
+                    "description": "Mount additional volumes into create user 
job",
+                    "type": "array",
+                    "default": []
+                },
+                "extraVolumeMounts": {
+                    "description": "Mount additional volumes into create user 
job",
+                    "type": "array",
+                    "default": []
+                },

Review comment:
       ```suggestion
                   "extraContainers": {
                       "description": "Launch additional containers for the 
create user job pod",
                       "type": "array",
                       "default": [],
                       "items": {
                           "$ref": 
"https://raw.githubusercontent.com/yannh/kubernetes-json-schema/master/v1.22.0-standalone-strict/container-v1.json";
                       }
                   },
                   "extraVolumes": {
                       "description": "Mount additional volumes into create 
user job",
                       "type": "array",
                       "default": [],
                       "items": {
                           "$ref": 
"https://raw.githubusercontent.com/yannh/kubernetes-json-schema/master/v1.22.0-standalone-strict/volume-v1.json";
                       }
                   },
                   "extraVolumeMounts": {
                       "description": "Mount additional volumes into create 
user job",
                       "type": "array",
                       "default": [],
                       "items": {
                           "$ref": 
"https://raw.githubusercontent.com/yannh/kubernetes-json-schema/master/v1.22.0-standalone-strict/volumemount-v1.json";
                       }
                   },
   ```
   
   We have more comprehensive validation now.

##########
File path: chart/values.schema.json
##########
@@ -1791,6 +1806,16 @@
                     "type": "array",
                     "default": []
                 },
+                "extraVolumes": {
+                    "description": "Mount additional volumes into migrate 
database job",
+                    "type": "array",
+                    "default": []
+                },
+                "extraVolumeMounts": {
+                    "description": "Mount additional volumes into migrate 
database job",
+                    "type": "array",
+                    "default": []
+                },

Review comment:
       ```suggestion
                   "extraVolumes": {
                       "description": "Mount additional volumes into migrate 
database job",
                       "type": "array",
                       "default": [],
                       "items": {
                           "$ref": 
"https://raw.githubusercontent.com/yannh/kubernetes-json-schema/master/v1.22.0-standalone-strict/volume-v1.json";
                       }
                   },
                   "extraVolumeMounts": {
                       "description": "Mount additional volumes into migrate 
database job",
                       "type": "array",
                       "default": [],
                       "items": {
                           "$ref": 
"https://raw.githubusercontent.com/yannh/kubernetes-json-schema/master/v1.22.0-standalone-strict/volumemount-v1.json";
                       }
                   },
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to