potiuk commented on a change in pull request #20319:
URL: https://github.com/apache/airflow/pull/20319#discussion_r770027301
##########
File path: airflow/providers/qubole/operators/qubole_check.py
##########
@@ -27,21 +27,26 @@
class _QuboleCheckOperatorMixin:
"""This is a Mixin for Qubole related check operators"""
+ kwargs: dict
+ results_parser_callable: Optional[Callable]
+
def execute(self, context=None) -> None:
"""Execute a check operation against Qubole"""
try:
self._hook_context = context
- super().execute(context=context)
+ super().execute(context=context) # type: ignore[misc]
Review comment:
I found a `better`? way of handling it. I think it's a bit nicer:
```
def execute(self: BaseOperator, context=None) -> None: # type: ignore[misc]
```
It's not as spectacular as in my case where I got rid of 5 self.* references
this way, but I think it is more explicit (the ignore above has to be added
silence another MyPy error "BaseOperator is not a superclass of Mixin'
https://github.com/apache/airflow/pull/20329/files#r770023071
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
