potiuk commented on a change in pull request #20344:
URL: https://github.com/apache/airflow/pull/20344#discussion_r770676925
##########
File path: airflow/providers/elasticsearch/log/es_task_handler.py
##########
@@ -62,6 +62,9 @@ class ElasticsearchTaskHandler(FileTaskHandler,
ExternalLoggingMixin, LoggingMix
MAX_LINE_PER_PAGE = 1000
LOG_NAME = 'Elasticsearch'
+ formatter: logging.Formatter
Review comment:
Are you sure you want to turn formatted and handler into "class"
attributes? What purpose will it have? I think they are never accessed via
"Class" object so when you assign something to self.formatter, you do not
actually assign it to the class attribute, but you have instance attribute
instead. I believe the values should be declared in `__init__` shouldn't they?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
