subkanthi commented on a change in pull request #20353:
URL: https://github.com/apache/airflow/pull/20353#discussion_r770952251
##########
File path: airflow/providers/amazon/aws/hooks/eks.py
##########
@@ -360,14 +360,19 @@ def get_cluster_state(self, clusterName: str) ->
ClusterStates:
:rtype: ClusterStates
"""
eks_client = self.conn
+ result = None
try:
- return
ClusterStates(eks_client.describe_cluster(name=clusterName).get('cluster').get('status'))
+ result =
ClusterStates(eks_client.describe_cluster(name=clusterName).get('cluster').get('status'))
Review comment:
Dont really want to change anything thats not related to mypy errors😄 ,
these are the errors and in the except there is no return for the if /else
clause. Maybe Im missing something
^
airflow/providers/amazon/aws/hooks/eks.py:352: error: Missing return
statement
def get_cluster_state(self, clusterName: str) -> ClusterStates:
^
airflow/providers/amazon/aws/hooks/eks.py:370: error: Missing return
statement
def get_fargate_profile_state(self, clusterName: str,
fargateProfileName: str) -> FargateProfileStates:
^
airflow/providers/amazon/aws/hooks/eks.py:396: error: Missing return
statement
def get_nodegroup_state(self, clusterName: str, nodegroupName: str)
-> NodegroupStates:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
