dstandish commented on a change in pull request #17934:
URL: https://github.com/apache/airflow/pull/17934#discussion_r771731034



##########
File path: chart/values.yaml
##########
@@ -1308,6 +1308,7 @@ dags:
     extraVolumeMounts: []
     env: []
     resources: {}
+    sshKeyCustomFile:

Review comment:
       i agree with @jedcunningham 
   
   and maybe what  we can do here is, `sshKeyFile` can have an explicit default 
of `/etc/git-secret/ssh`
   
   then we could reference this config instead of hardcoding e.g. in 
`_helpers.py` when setting `GIT_SSH_KEY_FILE`
   
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to