char101 commented on issue #20396:
URL: https://github.com/apache/airflow/issues/20396#issuecomment-997226083


   > You also need to update APIs for example to retrieve it
   
   At least adding a name field won't break the APIs. So changes can be 
implemented incrementally.
   
   > ID will (likely) change it's meaning of being name
   
   Why should id be changed into name? Just keep it that way but add an 
optional name parameter. This way backward compatibility can be maintained.
   
   > you have duplicate names
   
   Should not be a problem  just like two person can have the same name.
   
   > Should you be able to search by it
   
   Of course.
   
   > Should you be able to query by both id and name when hafl of your dags 
have names and the other does not?
   
   Name should be coalesced to id to maintain backward compatibility.
   
   > What should it look like in the UI when different name was used in the 
past and changed?
   
   This is versioning problem. What I am suggesting is the problem with the 
current airflow which does not have versioning. Past names should only appear 
in a history menu.
   
   > Should we keep the history of those names?
   
   This is the problem of versioning.
   
   All in all I think this is a separate problem and should not be viewed from 
the versioning point of view.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to