dstandish commented on a change in pull request #19572:
URL: https://github.com/apache/airflow/pull/19572#discussion_r771847798
##########
File path: airflow/providers/cncf/kubernetes/utils/pod_launcher.py
##########
@@ -320,20 +332,3 @@ def _exec_pod_command(self, resp, command: str) -> None:
self.log.info(resp.read_stderr())
Review comment:
looked a little more closely and understand a little better what this is
doing
this is actually a bit weird. it looks very similar to this example here:
https://github.com/kubernetes-client/python/blob/master/examples/pod_exec.py#L96-L107
but what that example is doing is looping through the log stream and
emitting stdout / stderr from each chunk as it goes.
what we are doing here _looks_ very similar. but we seem to return the
first time _anything_ goes to the logs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
