potiuk commented on pull request #20338:
URL: https://github.com/apache/airflow/pull/20338#issuecomment-997861621


   > Is this logical order right? Do I have to consider reading from cache 
`.build` directory in this task or is it a separate task to read from `.build` 
cache directory?
   
   Yeah. This is the righ order. I think it should be part of this task. 
   
   Just want to make sure that those cases are handled (some of it I added  
later in the process so this is a learnig i had):
   
   * when you run a command where parameters are used, the ".build" cache 
should be always overwritten with the current value (simply next run without 
parameter should use the same value)
   * when you find a value that is invalid in the cache, the cache for this 
parameter should be removed and the command should fail
   
   The last case is especially useful when we change default values. For 
example in a few days in Breeze we will remove python 3.6 as valid value 
because we will stop supporting Python 3.6 
(https://github.com/apache/airflow/blob/main/README.md#support-for-python-and-kubernetes-versions)
 - and in this case anyone who uses Breeze with Python 3.6 should "stop" doing 
it. What will happen is that "3.6" will be removed in .build/PYTHON_VERSION is 
stored as 3.6, and the command will fail with appropriate error message, but 
next time it will be run, the new default ("3.7" in this case) will be used 
(and stored in the cache). 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to