josh-fell commented on a change in pull request #20422:
URL: https://github.com/apache/airflow/pull/20422#discussion_r772414795
##########
File path:
airflow/providers/apache/cassandra/example_dags/example_cassandra_dag.py
##########
@@ -35,7 +35,9 @@
catchup=False,
tags=['example'],
) as dag:
- table_sensor = CassandraTableSensor(task_id="cassandra_table_sensor")
+ table_sensor = CassandraTableSensor(task_id="cassandra_table_sensor",
table="table")
- record_sensor = CassandraRecordSensor(task_id="cassandra_record_sensor",
keys={"p1": "v1", "p2": "v2"})
+ record_sensor = CassandraRecordSensor(
+ task_id="cassandra_record_sensor", keys={"p1": "v1", "p2": "v2"},
table="table"
+ )
Review comment:
I think we should keep the `table` arg value in `default_args` and add
the `type: ignore[call-arg]` comment instead. It seems like a proper fix is not
going to be trivial but ignoring that specific Mypy error is a good interim
solution.
The documentation for these sensors also references that the `table`
parameter is set in `default_args`.
cc @uranusjr @khalidmammadov (related your Slack conversation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
