kaxil commented on a change in pull request #20435: URL: https://github.com/apache/airflow/pull/20435#discussion_r772735437
########## File path: UPDATING.md ########## @@ -89,11 +89,11 @@ Smart sensors, an "early access" feature added in Airflow 2, are now deprecated See [Migrating to Deferrable Operators](https://airflow.apache.org/docs/apache-airflow/2.3.0/concepts/smart-sensors.html#migrating-to-deferrable-operators) for details on how to migrate. -### Task log filenames are not rendered from database entry instead of config value +### Task log templates are now read from the metadatabase instead of `airflow.cfg` -Previously, filename of a task’s log is dynamically rendered from the ``[core] log_filename_template`` config value at runtime. This resulted in unfortunate characteristics like it is inpractical to modify the config value after an Airflow instance is running for a while, since all existing task logs have be saved under the previous format and cannot be found with the new config value. +Previously, a task’s log is dynamically rendered from the `[core] log_filename_template` and `[core] task_log_prefix_template` config values at runtime. This resulted in unfortunate characteristics, e.g. it is impractical to modify the config value after an Airflow instance is running for a while, since all existing task logs have be saved under the previous format and cannot be found with the new config value. Review comment: ```suggestion Previously, a task’s log is dynamically rendered from the `[core] log_filename_template` and `[core] task_log_prefix_template` config values at runtime. This resulted in unfortunate characteristics, e.g. it is impractical to modify the config value after an Airflow instance is running for a while, since all existing task logs have been saved under the previous format and cannot be found with the new config value. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
