potiuk commented on a change in pull request #20329:
URL: https://github.com/apache/airflow/pull/20329#discussion_r773256178
##########
File path: airflow/providers/google/firebase/example_dags/example_firestore.py
##########
@@ -119,10 +119,6 @@
"csvOptions": {"skipLeadingRows": 1},
},
},
- source_objects=[
- f"{EXPORT_PREFIX}/all_namespaces/kind_{EXPORT_COLLECTION_ID}"
- f"/all_namespaces_kind_{EXPORT_COLLECTION_ID}.export_metadata"
- ],
Review comment:
It's remnant from previous (deprecated) way of using the operator. You
should not mix "source_objects" and "table_resource".
We coul probably add corresponding "source_uris" in the "table_resources"
but since I did not want to be "wrong" and make some mistake there, I prefered
to remove it (table_resources has many more optional fields that can be used).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
