Bowrna commented on a change in pull request #20407: URL: https://github.com/apache/airflow/pull/20407#discussion_r773774181
########## File path: dev/breeze/doc/adr/0005-preventing-using-contributed-code-when-building-images.md ########## @@ -0,0 +1,160 @@ +<!-- + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. + --> + +<!-- START doctoc generated TOC please keep comment here to allow auto update --> +<!-- DON'T EDIT THIS SECTION, INSTEAD RE-RUN doctoc TO UPDATE --> +**Table of Contents** *generated with [DocToc](https://github.com/thlorenz/doctoc)* + +- [5. Preventing using contributed code when building images](#5-preventing-using-contributed-code-when-building-images) + - [Status](#status) + - [Context](#context) + - [Decision](#decision) + - [Consequences](#consequences) + +<!-- END doctoc generated TOC please keep comment here to allow auto update --> + +# 5. Preventing using contributed code when building images + +Date: 2021-12-19 + +## Status + +Draft + +Builds on [4. Using Docker images as test environment](0004-using-docker-images-as-test-environment.md) + +## Context + +As described in [4. Using Docker images as test environment](0004-using-docker-images-as-test-environment.md), +Airflow CI system uses CI Docker image as consistent test execution environment. This environment provides +cacheability and rebuild capabilities that allow the image to be rebuilt quickly, incrementally based on +previous version of the images - whenever any of the source code, Python dependencies, System dependencies +are changed (in optimal way depending on the change). However, even with optimalizations, rebuilding +the image might take quite some time (when only sources change ~ 1 minute, but when system dependencies +change ~ 10 minutes). In certain cases we run (for the same Python version) 20 jobs that require the same Review comment: @potiuk could you explain me what jobs mean in this case? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
