jlouk opened a new pull request #20465: URL: https://github.com/apache/airflow/pull/20465
<!-- Thank you for contributing! Please make sure that your code changes are covered with tests. And in case of new features or big changes remember to adjust the documentation. Feel free to ping committers for the review! In case of existing issue, reference it using one of the following: closes: #ISSUE related: #ISSUE How to write a good git commit message: http://chris.beams.io/posts/git-commit/ --> Currently with the airflow helm chart there is difficulty interacting airflow with istio. If we want to combine the kubernetesexecutor (airflow helm chart) and istio as a means of DNS, we run into issues where each task does not terminate but rather stays in a "Completed" state while the istio-proxy continues listening. This creates a bottleneck for the dags to run. There is a k8s annotation that we can apply where the sidecar injection does not happen: `sidecar.istio.io/inject: "false"` Originally, I tried applying this annotation to airflowPodAnnotations in the values.yaml, but this also disabled the injection for the webserver, which was the only service I needed to inject for my use case. I experimented with setting airflowPodAnnotations to disable injection and specifically webserver annotations to `sidecar.istio.io/inject: "true"` but that left the webserver with two annotations - one true and one false. Instead, this change addresses client facing ui's that would benefit from istio injection, and disabling the istio sidecar injection on all other services. Assuming this change is deemed appropriate, further applications of this could be adding functionality to configuring istio gateways/virtualservices. Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information. In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed. In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
