dstandish commented on pull request #20463:
URL: https://github.com/apache/airflow/pull/20463#issuecomment-999736831
nothing to fix i'd say but i am curious why we no longer let the hook handle
auth more completely....
like it used to be
```python
s3_resource = self.get_resource_type('s3')
return s3_resource.Bucket(bucket_name)
```
but as of [this
change](https://github.com/potiuk/airflow/commit/83b51e53062dc596a630edd4bd01407a556f1aa6)
we have much more complicated expression and get our hands more dirty. just
curious for the reasoning on that. is there a reason not to let base hook
handle giving us an authenticated resource, instead of repeating that logic
within method calls?
also why _not_ let region_name be optional (i.e. have a default of None) in
`_get_credentials`? that doesn't necessarily harm backcompat
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
