potiuk commented on issue #19891: URL: https://github.com/apache/airflow/issues/19891#issuecomment-1001531572
> Question , looking at this PR, is the convention to not include the ASF source header for pyi files This is a very good point. Technically we should do it before we reease the files in our source package. I am not sure if we want to release them, but this is another question which i think will need to be answered separately - and I think we shoud have a spearate discussion on how and whether to release them: * we could not release them and only leave them in the repo * we could release them in sources or * we could release a separate typeshed package for those who want to use mypy https://github.com/python/typeshed But regardless of the discussion - those fiels are manualy modified so technically speaking they should be licenced. I will update the pre-commit to include generation of headers also in those files. So even if we will not release them, it makes no harrm to add licence header. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
