harishkrao commented on a change in pull request #20509:
URL: https://github.com/apache/airflow/pull/20509#discussion_r775727930



##########
File path: tests/providers/snowflake/hooks/test_snowflake.py
##########
@@ -388,3 +388,38 @@ def test_connection_failure(self, mock_run):
             assert status is False
             assert msg == 'Connection Errors'
             mock_run.assert_called_once_with(sql='select 1')
+
+    
@mock.patch('airflow.providers.snowflake.hooks.snowflake.SnowflakeHook.run')

Review comment:
       @mik-laj  Just saw that you modified the pytest connection parameters to 
allow a blank value for region. I attempted to write the same, but 
unsuccessfully, so added a new test. This is not needed, now that you have 
added the params.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to