Bowrna commented on a change in pull request #20338: URL: https://github.com/apache/airflow/pull/20338#discussion_r775869648
########## File path: dev/breeze/src/airflow_breeze/breeze.py ########## @@ -95,13 +96,46 @@ def shell(verbose: bool): @option_verbose [email protected]() -def build_ci_image(verbose: bool): - """Builds breeze.ci image for breeze.py.""" [email protected](name='build-ci-image') [email protected]( + '--additional-extras', + help='This installs additional extra package while installing airflow in the image.', +) [email protected]('-p', '--python', help='Choose your python version') [email protected]( + '--additional-dev-apt-deps', help='Additional apt dev dependencies to use when building the images.' +) [email protected]( + '--additional-runtime-apt-deps', + help='Additional apt runtime dependencies to use when building the images.', +) [email protected]( + '--additional-python-deps', help='Additional python dependencies to use when building the images.' +) [email protected]('--github-repository', help='Choose repository to push/pull image.') +def build_ci_image( + verbose: bool, + additional_extras: str, Review comment: Yes I will use Optional[str] here more often. It makes sense. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
