derkuci commented on pull request #20473: URL: https://github.com/apache/airflow/pull/20473#issuecomment-1002268405
Good point! Let's abandon the changes. My real point always has been that the `xcom_pull` result should be consistent, and whether an encoding/decoding is used shouldn't matter to the user. Since `enable_xcom_pickling=False` (which uses json) is quite limited in the data types that can be serialized, we chose to uuencode the return value from the `SSHOperator`, which causes the inconsistency. It works, though, as you indicated. However, if "arbitrary binary return value" + "json serialization" is what we want to support, we should wrap json to deal with binary data, instead of forcing `SSHOperator` to do the encode work --- what about other operators that may return binary data? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
