potiuk commented on a change in pull request #20238:
URL: https://github.com/apache/airflow/pull/20238#discussion_r776087280



##########
File path: Dockerfile
##########
@@ -62,6 +65,7 @@ ENV PYTHON_BASE_IMAGE=${PYTHON_BASE_IMAGE} \
 
 # Install curl and gnupg2 - needed for many other installation steps
 RUN apt-get update \
+    && apt-get install --no-install-recommends -yqq apt-utils >/dev/null 2>&1 \

Review comment:
       Because we need curl/gpg2 to run DEV_APT_COMMAND  - and we can 
potentially override this commmand (and we need curl/gpg2 to be able to install 
"extra resources" if needed. I prefer to install curl/gpg2 using "official 
sources" first - to be able to add "new sources" later. Otherwise it would 
require anyhow to run the "apt update" two times - once with the oriignal 
sources to update curl/gpg2, downloading keys for the "secondary" sources, and 
running apt-update again. The optimisations we can get this way are minimal, 
and it's much better to separate the concerns - the ommand to run all of that 
in one RUN would be pretty long.. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to