potiuk commented on a change in pull request #20482:
URL: https://github.com/apache/airflow/pull/20482#discussion_r776304364



##########
File path: airflow/utils/context.pyi
##########
@@ -48,7 +48,7 @@ class VariableAccessor:
 class ConnectionAccessor:
     def get(self, key: str, default_conn: Any = None) -> Any: ...
 
-class Context(TypedDict, total=False):
+class Context(TypedDict, total=False):  # type: ignore

Review comment:
       `total=False` is Python 3.8 + feature 
https://docs.python.org/3/whatsnew/3.8.html
   Not sure if  it will be really helpful. I'd say we should specify all 
possible keys in  Context.  




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to