dstandish commented on a change in pull request #20495:
URL: https://github.com/apache/airflow/pull/20495#discussion_r776572180
##########
File path: airflow/providers/snowflake/hooks/snowflake.py
##########
@@ -310,14 +309,14 @@ def run(
self.log.info("Rows affected: %s", cur.rowcount)
self.log.info("Snowflake query id: %s", cur.sfqid)
- self.query_ids.append(cur.sfqid)
+ query_ids.append(cur.sfqid)
# If autocommit was set to False for db that supports autocommit,
# or if db does not supports autocommit, we do a manual commit.
if not self.get_autocommit(conn):
conn.commit()
- return execution_info
+ return execution_info, query_ids
Review comment:
yup it seems like we cannot practically make this change. it seems that
the issue i created (https://github.com/apache/airflow/issues/20398) is not a
good issue, since there's not really a practical way to get around it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
