BasPH commented on a change in pull request #20574:
URL: https://github.com/apache/airflow/pull/20574#discussion_r776641171
##########
File path: airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py
##########
@@ -491,9 +491,9 @@ def on_kill(self) -> None:
def build_pod_request_obj(self, context=None):
"""
- Creates a V1Pod based on user parameters. Note that a `pod` or
`pod_template_file`
- will supersede all other values.
+ Returns V1Pod object based on pod template file, full pod spec, and
other operator parameters.
+ Full pod spec overrides pod template, and operator params take highest
precedence.
Review comment:
Would reverse the order so that the most important variable is mentioned
first:
```suggestion
The V1Pod attributes are selected from (first to last): operator
params, full pod spec, pod template file.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
