potiuk commented on a change in pull request #20570:
URL: https://github.com/apache/airflow/pull/20570#discussion_r776699687
##########
File path: airflow/providers/google/cloud/operators/dataproc.py
##########
@@ -1257,7 +1265,11 @@ def generate_job(self):
:return: Dict representing Dataproc job
"""
self.create_job_template()
+ if self.job_template is None:
+ raise AirflowException('Job should be set here')
Review comment:
No. But I have no idea how to make it in the way that MyPy does not
complain. It's just badly structured I think - it should not store the job as
self but create_job_template should rather return the templte which is "not
None". But I think this might be a separate refactor when the time comes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
