potiuk commented on a change in pull request #20590:
URL: https://github.com/apache/airflow/pull/20590#discussion_r776803969
##########
File path: airflow/providers/amazon/aws/transfers/ftp_to_s3.py
##########
@@ -132,12 +132,13 @@ def execute(self, context: 'Context'):
if self.ftp_filenames == '*':
files = list_dir
else:
- files = list(filter(lambda file: self.ftp_filenames in
file, list_dir))
+ ftp_filename: str = self.ftp_filenames
+ files = list(filter(lambda f: ftp_filename in f, list_dir))
Review comment:
I think the main problem here is that `mypy` cannot reliably tell it fhe
self.ftp_filenams have been overwritten by something lese. we are executing
some methods on self that could potentially override it a better solution will
proably be to do this assignment before is_instance (and then you will not have
to do the second check).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
