dstandish commented on a change in pull request #20573:
URL: https://github.com/apache/airflow/pull/20573#discussion_r776804814
##########
File path: airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py
##########
@@ -573,6 +573,15 @@ def build_pod_request_obj(self, context=None):
)
return pod
+ def dry_run(self) -> None:
+ """
+ Prints out the pod definition that would be created by this operator.
+ Does not include labels specific to the task instance (since there
isn't
+ one in a dry_run) and excludes all empty elements.
+ """
+ pod = self.build_pod_request_obj()
Review comment:
oh with regard to dry run... i think you're right we probably should run
it through the mutation hook.
you know... this is interesting.... mutating the pod in launcher is
actually not great i don't think. we should mutate it in
`build_pod_request_obj`
ideally, the pod returned from `build_pod_request_obj` should be the actual
pod requested.
wdyt @kaxil
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
