kaxil commented on a change in pull request #20575:
URL: https://github.com/apache/airflow/pull/20575#discussion_r776808407



##########
File path: airflow/providers/amazon/aws/operators/eks.py
##########
@@ -18,12 +18,13 @@
 """This module contains Amazon EKS operators."""
 import warnings
 from time import sleep
-from typing import Dict, Iterable, List, Optional
+from typing import Dict, Iterable, List, Optional, Union
 
 from airflow import AirflowException
 from airflow.models import BaseOperator
 from airflow.providers.amazon.aws.hooks.eks import ClusterStates, EksHook, 
FargateProfileStates
 from airflow.providers.cncf.kubernetes.operators.kubernetes_pod import 
KubernetesPodOperator
+from airflow.utils.types import NOTSET, ArgNotSet

Review comment:
       While they are in the same repo, you should really think of it like a 
Terraform provider which is in a separate repo and a separate source code, just 
depends on the core.
   
   And especially for **utilities** not rely on the core package




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to