uranusjr commented on a change in pull request #20361:
URL: https://github.com/apache/airflow/pull/20361#discussion_r778521582
##########
File path: airflow/utils/operator_helpers.py
##########
@@ -75,6 +86,19 @@ def context_to_airflow_vars(context: Mapping[str, Any],
in_env_var_format: bool
(dag_run, 'run_id', 'AIRFLOW_CONTEXT_DAG_RUN_ID'),
]
+ context_params = settings.get_airflow_context_vars(context)
+ for key, value in context_params.items():
+ assert type(key) == str, "key must be string"
+ assert type(value) == str, "value must be string"
Review comment:
This should use `isinstance` instead IMO. There’s also a rule to not use
asserts in the code base (although I personally disagree with)
https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#don-t-use-asserts-outside-tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
