kaxil opened a new pull request #20663:
URL: https://github.com/apache/airflow/pull/20663


   This was updated in Airflow 2.2.0 via 
https://github.com/apache/airflow/pull/16634 which restricts a user to even 
views the DagRuns and TI records if they don't have "edit" permissions on DAG 
even though it has "read" permissions.
   
   The Behaviour seems inconsistent as a User can still view those from the 
Graph and Tree View of the DAG.
   
   And since we have got `@action_has_dag_edit_access` on all the Actions like 
Delete/Clear etc the approach in this PR is better as when a user will try to 
perform any actions from the List Dag Run view like deleting the record it will 
give a Access Denied error.
   
   cc @Jorricks
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)**
 for more information.
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to