potiuk commented on a change in pull request #20678:
URL: https://github.com/apache/airflow/pull/20678#discussion_r778781006
##########
File path: scripts/docker/install_pip_version.sh
##########
@@ -30,11 +30,13 @@
. "$( dirname "${BASH_SOURCE[0]}" )/common.sh"
function install_pip_version() {
- pip install --no-cache-dir --upgrade "pip==${AIRFLOW_PIP_VERSION}" &&
mkdir -p /root/.local/bin
+ pip install --disable-pip-version-check --no-cache-dir --upgrade
"pip==${AIRFLOW_PIP_VERSION}" &&
+ mkdir -p ${HOME}/.local/bin
Review comment:
As far as I remember it related to the warnings printed by PIP.
If we have no `bin` directory on PATH there is a warning generated by `pip`
when --user flag is used and `~/.local/bin` is not in the PATH.
We have (in Dockerfiles) this one to avoid the warning:
```
PATH=${PATH}:/root/.local/bin
```
And I just feel uncomfortable having a directory that is not existing on the
PATH (not sure if `pip` checks if the directory is present, but i prefer to
have it regardless).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
