eladkal commented on a change in pull request #20669:
URL: https://github.com/apache/airflow/pull/20669#discussion_r778842284
##########
File path: airflow/contrib/operators/ecs_operator.py
##########
@@ -19,26 +19,12 @@
import warnings
-from airflow.providers.amazon.aws.operators.ecs import ECSOperator,
ECSProtocol as NewECSProtocol # noqa
-from airflow.typing_compat import Protocol, runtime_checkable
+from airflow.providers.amazon.aws.operators.ecs import ECSOperator, ECSProtocol
Review comment:
Is `pytest -s tests/core/test_core_to_contrib.py` passing? (I'm not
sure if the test is executed as it's a core test)
I wonder if it causes troubles as we have a deprecated class pointing to a
deprecated class
https://github.com/apache/airflow/blob/61b29d7454f024efce63a2cb684eb876ec7e4856/tests/deprecated_classes.py#L1067-L1068
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
