uranusjr commented on a change in pull request #20657:
URL: https://github.com/apache/airflow/pull/20657#discussion_r779293052
##########
File path: airflow/jobs/triggerer_job.py
##########
@@ -382,8 +382,8 @@ def update_triggers(self, requested_trigger_ids: Set[int]):
# handling.
current_trigger_ids = set(self.triggers.keys())
# Work out the two difference sets
- new_trigger_ids = requested_trigger_ids.difference(current_trigger_ids)
- old_trigger_ids = current_trigger_ids.difference(requested_trigger_ids)
+ new_trigger_ids = requested_trigger_ids - current_trigger_ids
+ remove_trigger_ids = current_trigger_ids - requested_trigger_ids
Review comment:
@dstandish Do you want to change this? Personally I like the
`...to_remove` name slightly better as well since `remove_...` sounds like a
verb, not a noun. But if you like the current name better, let’s get this
merged as-is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
