kaxil commented on a change in pull request #20353:
URL: https://github.com/apache/airflow/pull/20353#discussion_r779601819
##########
File path: airflow/providers/amazon/aws/hooks/athena.py
##########
@@ -228,7 +228,7 @@ def poll_query_status(self, query_execution_id: str,
max_tries: Optional[int] =
sleep(self.sleep_time)
return final_query_state
- def get_output_location(self, query_execution_id: str) -> str:
+ def get_output_location(self, query_execution_id: str) -> Optional[str]:
Review comment:
In the following block, the only way the `output_location` can be `None`
is if `response` is a false-y value which does not look like it is possible
from
https://boto3.amazonaws.com/v1/documentation/api/1.9.42/reference/services/athena.html#Athena.Client.get_query_execution
and
https://docs.aws.amazon.com/athena/latest/APIReference/API_GetQueryExecution.html
https://github.com/apache/airflow/blob/d9259a556e9ae4c60edad9d1374ca0c7a9d2fa58/airflow/providers/amazon/aws/hooks/athena.py#L240-L251
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
